Skip to content

fix(utils): reject trailing characters in numFromString - #2166

Merged
dankmeme01 merged 3 commits into
geode-sdk:mainfrom
slideglide:main
Aug 27, 2026
Merged

fix(utils): reject trailing characters in numFromString#2166
dankmeme01 merged 3 commits into
geode-sdk:mainfrom
slideglide:main

Conversation

@slideglide

@slideglide slideglide commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

this PR is dedicated to ery

  • fixes a bug where numFromString returned an Ok for strings containing valid numeric prefixes followed by unparsed trailing characters
  • returns the message of the error code instead of returning "Unknown error"
  • trailing data error returns "String contains trailing data" instead of "String contains trailing extra data" (extra is unnecessary here imo)

see the screenshots for reference

Screenshot_2026-08-23_at_7 19 35_AM Screenshot_2026-08-23_at_7 19 55_AM

@dankmeme01
dankmeme01 merged commit 34a11b6 into geode-sdk:main Aug 27, 2026
6 checks passed
dankmeme01 added a commit that referenced this pull request Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants